[bug] DA 1.46.3, nginx_apache: ServerAlias is added into nginx_server_sub.conf

Hello,





Directadmin:

Compile Date	Oct 24 2014, 20:35:39
Server Version	1.46.3

[root@shared custombuild]# ./build version

2.0.0-RC7 (rev: 1076)





Let's say we have:



1. domain.com

domain2.com, domain3.com as aliases to domain.com



2. domain.com has subs:

sub1, sub2, sub3.



Thus we have



domain.com with aliases: domain2.com, domain3.com

sub1.domain.com with aliases: sub1.domain2.com, sub1.domain3.com

sub2.domain.com with aliases: sub2.domain2.com, sub2.domain3.com

sub3.domain.com with aliases: sub3.domain2.com, sub3.domain3.com



Directadmin completely wrong sets aliases in /usr/local/directadmin/data/templates/nginx_server_sub.conf
a new line with ServerAlias is added (from apache version I guess):

we've got:

Code:

---

server_name sub1.domain.com www.sub1.domain.com

ServerAlias sub1.domain1.com www.sub1.domain1.com sub1.domain2.com www.sub1.domain3.com sub1.domain3.com www.sub3.domain.com;

---

And nginx warns about:

Code:

---

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

nginx: [warn] conflicting server name "serveralias" on 11.22.33.44:80, ignored

---

[bug] DA 1.46.3, nginx_apache: ServerAlias is added into nginx_server_sub.conf